Repository navigation
fix(sdk): preserve distinct schemas with colliding model names - #1460
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1457.
Reserve generated model names by schema identity before rendering fields or method return types. Distinct schema paths that flatten to the same Python name receive deterministic path-derived suffixes, including component-versus-inline and response collisions. Unambiguous names retain their existing spelling, and a final uniqueness check prevents silent duplicate definitions.
Existing stored SDKs are unchanged until regenerated. No API, permissions, dependencies, or install steps change.
Reported by @MTG-Thomas in #1457.
Validation
./test.sh tests/unit/services/test_sdk_generator_model_names.py tests/unit/services/test_sdk_generator_descriptions.py tests/unit/services/test_sdk_generator_source_safety.py tests/unit/services/test_sdk_generator_url_validation.py tests/unit/services/test_sdk_generator_client_pool.py— 53 passed, zero skipped../test.sh quality api— Python lint and type checks.Product Updates
Omit: routine SDK generator correctness repair, with no new feature or breaking contract.